Dear Wolfram Sang, > > > > diff --git a/arch/arm/boot/dts/imx28.dtsi > > > > b/arch/arm/boot/dts/imx28.dtsi index ee3778a..832d30a 100644 > > > > --- a/arch/arm/boot/dts/imx28.dtsi > > > > +++ b/arch/arm/boot/dts/imx28.dtsi > > > > [...] > > > > > > @@ -428,6 +429,7 @@ > > > > > > > > compatible = "fsl,imx28-i2c"; > > > > reg = <0x8005a000 2000>; > > > > interrupts = <110 69>; > > > > > > > > + clock-frequency = <400000>; > > > > > > NACK on that. Not all slaves can do 400KHz, so this is not a sensible > > > default. > > > > How many of such chips are there and how many of the chips can do 400kHz > > ? I believe the majority shouldn't suffer because of minority. > > The kernel should work for all users, not only for the majority, so: > Better safe than sorry. > > Also, defaults should make the system work. Tuning can be done later by > somebody who understands what is needed. > > And frankly, this attitude which made you add a potential regression is > worrisome. I'd suggest to give stability a higher priority. I believe you misunderstood my intention. Setting it to 400kHz was done because it's what most people will use, therefore avoiding duplication (most of the board files will override this setting now). All right, your sane defaults here can be applied, I won't argue. And frankly, you could have left the last jab out. Let's avoid attacking each other, I'm not in the mood for it today. > Regards, > > Wolfram Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
