On Wed, Jun 20, 2012 at 2:56 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote: > Here we apply the bindings required for successful Device Tree > probing of the i2c-nomadik driver. We also apply a fall-back > configuration in case either one is not provided, or a required > element is missing from the one supplied. > > Cc: linux-i2c@xxxxxxxxxxxxxxx > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> Pls Cc Srinidhi on these patches, and I would prefer to get his ACK on this. Srinidhi, could you propose a patch to MAINTAINERS adding yourself as explicit maintainer for this driver? > +static struct nmk_i2c_controller u8500_i2c = { > + /* > + * Slave data setup time; 250ns, 100ns, and 10ns, which > + * is 14, 6 and 2 respectively for a 48Mhz i2c clock. > + */ > + .slsu = 0xe, > + .tft = 1, /* Tx FIFO threshold */ > + .rft = 8, /* Rx FIFO threshold */ > + .clk_freq = 100000, /* std. mode operation */ As per earlier discussion, change this default value to 400000. > + .timeout = 200, /* Slave response timeout(ms) */ > + .sm = I2C_FREQ_MODE_FAST, > +}; Thanks, Lmims Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html