On Wed, May 16, 2012 at 03:41:17PM +0200, Marek Vasut wrote: > Dear Felipe Balbi, > > > On Tue, May 15, 2012 at 10:23:37AM +0200, Marek Vasut wrote: > > > This codes connects the CI13xxx driver with the core found inside of > > > the Freescale i.MX244/i.MX28 CPU. > > > > > > Signed-off-by: Marek Vasut <marex@xxxxxxx> > > > Cc: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > > > Cc: Detlev Zundel <dzu@xxxxxxx> > > > CC: Dong Aisheng <b29396@xxxxxxxxxxxxx> > > > CC: Fabio Estevam <fabio.estevam@xxxxxxxxxxxxx> > > > Cc: Felipe Balbi <balbi@xxxxxx> > > > Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> > > > Cc: Linux ARM kernel <linux-arm-kernel@xxxxxxxxxxxxxxxxxxx> > > > Cc: linux-i2c@xxxxxxxxxxxxxxx > > > CC: Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> > > > CC: Shawn Guo <shawn.guo@xxxxxxxxxx> > > > Cc: Stefano Babic <sbabic@xxxxxxx> > > > CC: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > Cc: Wolfgang Denk <wd@xxxxxxx> > > > Cc: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > > > --- > > > > > > drivers/usb/chipidea/Makefile | 4 + > > > drivers/usb/chipidea/ci13xxx_mxs.c | 201 > > > ++++++++++++++++++++++++++++++++++++ 2 files changed, 205 insertions(+) > > > create mode 100644 drivers/usb/chipidea/ci13xxx_mxs.c > > > > > > diff --git a/drivers/usb/chipidea/Makefile > > > b/drivers/usb/chipidea/Makefile index cc34937..266d57d 100644 > > > --- a/drivers/usb/chipidea/Makefile > > > +++ b/drivers/usb/chipidea/Makefile > > > @@ -12,3 +12,7 @@ endif > > > > > > ifneq ($(CONFIG_ARCH_MSM),) > > > > > > obj-$(CONFIG_USB_CHIPIDEA) += ci13xxx_msm.o > > > > > > endif > > > > > > + > > > +ifneq ($(CONFIG_ARCH_MXS),) > > > + obj-$(CONFIG_USB_CHIPIDEA) += ci13xxx_mxs.o > > > +endif > > > > NAK... let it compile everywhere. > > I just followed the pattern here, honestly I think this is quite OK so far. > Further improvements can be made indeed. why introduce something we know will change ? Just make sure your code compiles everywhere. What's already there can be changed afterwards. > > > + *data->pdev->dev.dma_mask = DMA_BIT_MASK(32); > > > + data->pdev->dev.coherent_dma_mask = DMA_BIT_MASK(32); > > > > why don't you just point to the parent's ? > > Good idea, thanks :) no problem ;-) -- balbi
Attachment:
signature.asc
Description: Digital signature
