On Mon, May 14, 2012 at 04:57:39PM +0100, Lee Jones wrote:
> >> pdata = dev_get_platdata(ab8500->dev);
> >>- if (!pdata) {
> >>- dev_err(&pdev->dev, "null pdata\n");
> >>+ if (!pdata&& !np) {
> >>+ dev_err(&pdev->dev, "null pdata and no device tree found\n");
> >> return -EINVAL;
> >> }
> >Neither should be mandatory.
> Unfortunately, this has to reside, as without it I'd have to
> re-write the driver. Something with is completely out of scope of
> what I'm trying to achieve right now. It's something I'd be happy to
> do in the future, but not in this patch-set.
Why do you need to rewrite the driver? That doesn't sound terribly
plausible... The normal approach to this stuff is to allocate a
platform data struct unconditionally, why is this impossible in your
case?
Attachment:
signature.asc
Description: Digital signature
