On Saturday 12 May 2012 11:40 PM, Wolfram Sang wrote: >> Cc: Kevin Hilman <khilman@xxxxxx> >> > Cc: Rajendra Nayak <rnayak@xxxxxx> >> > Signed-off-by: Shubhrajyoti D <shubhrajyoti@xxxxxx> > I'd really like a comment from the PM experts if each and every driver > has to ensure that the clocks are enabled on remove like this? Just resent cc ing linux-pm BTW also found that Some others are also doing the same. eg: drivers/mmc/host/omap_hsmmc.c static int __devexit omap_hsmmc_remove(struct platform_device *pdev) { struct omap_hsmmc_host *host = platform_get_drvdata(pdev); struct resource *res; pm_runtime_get_sync(host->dev); mmc_remove_host(host->mmc); 2. drivers/usb/musb/musb_core.c static void musb_shutdown(struct platform_device *pdev) { struct musb *musb = dev_to_musb(&pdev->dev); unsigned long flags; pm_runtime_get_sync(musb->controller); Anyways will wait for feedback. > >> > --- >> > drivers/i2c/busses/i2c-omap.c | -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html