On Mon, May 07, 2012 at 10:18:45AM -0600, Stephen Warren wrote: > On 05/07/2012 12:46 AM, Laxman Dewangan wrote: > > Use the devm_* for the memory region allocation, interrupt request, > > clock handler request. > > By doing this, it does not require to explicitly free it and hence > > saving some code. > > > > Signed-off-by: Laxman Dewangan <ldewangan@xxxxxxxxxx> > > Acked-by: Stephen Warren <swarren@xxxxxxxxxxxxx> > > Note thought that devm_clk_get() appears to have been introduced very > recently in linux-next, so in order to merge this patch one of the > following has to happen: > > a) This patch goes through the tree that merged the addition of > devm_clk_get() (which I think is Russell King's ARM tree) I think it would be way more fitting if those go in via I2C. > b) Whichever tree takes this patch must first merge a branch that > contains that patch that adds devm_clk_get(). I have been pointed recently to subtle bugs when converting to devm_*. Even more, there is still the ongoing idea of platform_devm_* to simplify further. I need to scratch my head about those in general, but I won't do this before my 10 day vacation starting tomorrow. Until I am done with that, the devm_get_clock is probably in mainline. While devm_* patches are nice, they are not really critical. So, I prefer to take some extra time to get it right. Thanks, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature