On Fri, May 4, 2012 at 8:23 PM, Lee Jones <lee.jones@xxxxxxxxxx> wrote: > This patch will allow the ab8500-core driver to be probed and set up > when booting when Device Tree is enabled. This includes platform ID > look-up which identifies the machine it is currently running on. If > we are undergoing a DT enabled boot, we will refuse to setup each of > the other ab8500-* devices, as they will be probed individually by DT. > > Signed-off-by: Lee Jones <lee.jones@xxxxxxxxxx> (...) > + else if (np) > + ret = of_property_read_u32(np, "stericsson,irq-base", &ab8500->irq_base); > + > + if (ab8500->irq_base == 0) { Shouldn't this be (av8500->irq_base == NO_IRQ) now that we're tranisitioning to use 0 as NO_IRQ? Apart from that it looks good to me: Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx> Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html