On Tue, May 08, 2012 at 01:04:49PM +0100, Lee Jones wrote: > On 07/05/12 18:08, Mark Brown wrote: > >You should be using of_regulator_match() for this (I think it's supposed > >to do an equivalent job...) rather than open coding. > of_regulator_match() didn't exist when I wrote this. In fact, it > only made it into -next a couple of days ago. Besides, it doesn't It's been kicking around for review for a little while longer than that (it was waiting for review while Rhyland was on holiday), and in any case half the reason for adding infrastructure is to avoid adding repeated code. > satisfy the needs of this code segment. of_regulator_match() is > a(nother) wrapper around of_get_regulation_constraints(), which is > only used to populate 'struct regulation_constraints constraints' > after being provided with a selection of .compatible strings. I suspect that what you're trying to achieve isn't a good regulator binding but I'm not entirely sure what you're trying to do so perhaps not. You haven't documented the binding at all which might make things clearer...
Attachment:
signature.asc
Description: Digital signature
