On Mon, May 07, 2012 at 03:14:00PM +0800, Dong Aisheng wrote: > As IMX, basically i'd prefer to add pinctrl states in dts file at the > same time within the patch or using a separate patch to add them before > this series to avoid breaking the exist platforms. > > However i noted that for mxs, most drivers here are still not dt capable, > so it may be ok to not add their pinctrl state at this time. > There no mxs driver on mainline that has been DT aware of. What I'm going to do is to ask Arnd abandon the mxs/dt branch I sent him before and send him an updated one with the whole mxs DT support based on mxs common clk and pinctrl series. > But for the patch "serial: amba-pl011: adopt pinctrl support" since it is > dt capable, so with this patch applied, the mx28 dt boot will fail. > Maybe we should at least add pinctrl states for amba-pl011 first. > The updated mxs/dt will have pinctrl defined in dts for each device that is converted to DT. > > Shawn Guo (9): > > ARM: mxs: enable pinctrl dummy states > > serial: amba-pl011: adopt pinctrl support > BTW, will this one break other platforms using this driver? > If the platforms do not turn on CONFIG_PINCTRL, they are fine. If they turn on the support, they should provide pinctrl state either dummy or real one. -- Regards, Shawn -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html