Dear Uwe Kleine-König, > On Fri, Apr 27, 2012 at 11:51:56AM -0300, Fabio Estevam wrote: > > Hi Wolfram, > > > > On Fri, Apr 27, 2012 at 11:23 AM, Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote: > > > if (i2c->cmd_err == -ENXIO) > > > mxs_i2c_reset(i2c); > > > + else > > > + writel(MXS_I2C_QUEUECTRL_QUEUE_RUN, > > > + i2c->regs + MXS_I2C_QUEUECTRL_CLR); > > > > When setting the QUEUE_RUN, do we really want to clear all the other > > bits of QUEUECTRL_CLR register? > > > > I am wondering if we should only set QUEUE_RUN bit here. > > I didn't check the manual, but I guess writing to MXS_I2C_QUEUECTRL_CLR > just clears the QUEUE_RUN bit and nothing else?! I think the RUN bit will be cleared by the controller anyway, so this patch is pointless. > > Best regards > Uwe Best regards, Marek Vasut -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
