Hi Niko, you a right. Driver works with that patch. Mit freundlichen Grüßen / Best regards Carsten Behling Development Engineer Garz & Fricke GmbH Tempowerkring 2, 21079 Hamburg - Germany Amtsgericht Hamburg HRB 60514 Geschäftsführer: Manfred Garz, Matthias Fricke Phone: +49 (0) 40 791 899 - 56 Fax: +49 40 / 791 899 - 39 www.garz-fricke.com -----Ursprüngliche Nachricht----- Von: Voss, Nikolaus [mailto:N.Voss@xxxxxxxxxxx] Gesendet: Freitag, 27. April 2012 10:05 An: Carsten Behling Cc: Marc-Oliver Westerburg; 'devel@xxxxxxxxxx'; 'Wolfram Sang'; 'linux-arm-kernel@xxxxxxxxxxxxxxxxxxx'; 'linux-kernel@xxxxxxxxxxxxxxx'; 'linux-i2c@xxxxxxxxxxxxxxx'; 'Hubert Feurstein' Betreff: RE: [PATCH v10 3/4] drivers/i2c/busses/i2c-at91.c: add new driver Hi Carsten, Carsten Behling wrote on 2012-04-27: >> INIT_COMPLETION(dev->cmd_complete); >> + dev->transfer_status = 0; >> if (dev->msg->flags & I2C_M_RD) { >> unsigned start_flags = AT91_TWI_START; > > this patch will not work, because you reset 'dev->transfer_status' > before it is evaluated on errors (AT91_TWI_NACK, AT91_TWI_OVRE). it should, because transfer_status is updated by the ISR between wait_for_completion_interruptible_timeout() and the error evaluation. Please try it out. > > P.S. Are you using a RM9200? Seems that this SOC has some problems... > > Yes, our ECO920 uses the RM9200, but we support it with an very old kernel > (2.6.21). I remember there were many problems with I2C. Ok, but good to hear the driver basically works with the RM9200. Niko -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
