On Tue, Apr 17, 2012 at 11:39 PM, Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote: > >> >> From: Jonas Aaberg <jonas.aberg@xxxxxxxxxxxxxx> >> >> >> >> Turn off the clock and regulator to the I2C block using runtime >> >> PM. >> >> >> >> Cc: Magnus Damm <magnus.damm@xxxxxxxxx> >> >> Cc: Rafael J. Wysocki <rjw@xxxxxxx> >> >> Cc: Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> >> >> Signed-off-by: Jonas Aaberg <jonas.aberg@xxxxxxxxxxxxxx> >> >> Signed-off-by: Linus Walleij <linus.walleij@xxxxxxxxxx> >> > >> > Dooks, are you OK with merging this patch now? >> > > As I understood, Mark acked it? I didn't dive into the details, so it would be > nice for me to have an ACK (or at least a not NACK) from Magnus. I'm a bit hesitant to ack because the runtime suspend/resume callbacks are used differently than we would do on arch/sh and arch/arm/mach-shmobile. This difference may or may not be a good thing. I'm afraid I know too little about the nomadik platform to say anything wise. =) Our drivers assume that the ->runtime_suspend() and ->runtime_resume() callbacks are executed before/after the power is turned off/on for a certain power domain. The way they are used in this patch more seems like they are expected to be called regardless of the state of the rest of the devices sharing the underlying power domain. You probably want to control the clocks and the regulators directly - independently of the rest of the devices.You may want to look into struct gpd_dev_ops for various ways to interface to the pm domain code. Exactly what is a good fit depends on how the underlying SoC code maps the runtime pm clock and domain code to the actual hardware. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
