Re: [PATCHv5 16/18] I2C: OMAP: fix missing handling of errata I2C_OMAP3_1P153

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Shubhro,

On 04/04/2012 12:45 PM, Shubhrajyoti Datta wrote:
Hi Jon,


+       if (dev->flags&    OMAP_I2C_FLAG_APPLY_ERRATA_I207)

+               dev->errata |= I2C_OMAP_ERRATA_I207;
+
        if (dev->rev<= OMAP_I2C_REV_ON_3430_3530)
                dev->errata |= I2C_OMAP3_1P153;


The errata ID is not correct. I believe that 1P153 is referring to the
section number in the errata doc and not the errata ID. The errata ID should
be i451 in the latest OMAP34xx and OMAP36xx docs.

Please can you update this? The section number changed in the latest errata
docs and it took me a minute to find this.

Do you mind if that is a separate patch?

Not at all and in fact it probably should be.

Thanks
Jon
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux