Re: [PATCH v3] i2c-ali1535: enable SPARC support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, November 28, 2011 12:19 pm, corentin.labbe wrote:
> Le 25/11/2011 14:23, Jean Delvare a écrit :
>> From: "corentin.labbe" <corentin.labbe@xxxxxxxxxxx>
>>
>> The i2c-ali1535 driver don't work on SPARC, this is because it assumes that
>> ioport address are 16bits wide (address stored with an unsigned short).
>> But on SPARC arch, ioports are mapped in memory and so are stored with an
>> unsigned long.
>>
>> This patch corrects this by using pci_resource_start for getting IOMEM base
>> address, then reading the SMBBA of the i2c busse and using together for I/O
>> access.
>>
>> I like to thanks Jean DELVARE for reviewing of my patch.
>>
>> Signed-off-by: LABBE Corentin <corentin.labbe@xxxxxxxxxxx>
>> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
>> ---
>> Corentin, I rebased your patch so that it applies on top of the fix I
>> just sent. I also turned one dev_info into dev_dbg, and relaxed the
>> check on the PCI resource flags: I have no idea if the resource is
>> always defined, in particular on x86, and as it will be difficult to
>> find testers, I want to play it safe and guarantee that the driver will
>> behave the same way it used to before your patch.
>>
>> Corentin, Pierre-Yves, please test this version of the patch on top of
>> the fix I just sent, and confirm that it works for you.
>
> It works for me.
>
> Thanks for your work.
>

Works for me too, thanks!

-- 
Pierre-Yves Rofes

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux