Hi Benjamin, On Tue, 05 Jul 2011 17:20:40 +1000, Benjamin Herrenschmidt wrote: > On Fri, 2011-04-22 at 20:18 +0200, Jean Delvare wrote: > > Note that I think it would make a lot of sense to expose all the > > monitored values at least read-only through a hwmon-style interface in > > all these powermac specific drivers. This would let these values be > > reported to users by all standard monitoring tools. > > > > Independent from the warnings you were reported, though. > > Ok, I've finally decided to dedicate a couple of days in fixing them, > it's non-trivial, but I'm getting there slowly. In some cases (windfarm) > it's easy and actually removes significant amounts of code from the > drivers. In other cases, it's harder because the drivers are pretty > awful in the first place (therm_adt746x). I am glad to hear that the change will simplify the code in at least some cases. > I might completely replace therm_pm72 with a windfarm implementation for > those older G5's which would be more consistent (all G5's would thus use > windfarm) since it's cleaner (therm_pm72 hard code i2c addresses etc... > while windfarm is meant for more dynamic probing of the sensors). > > Regarding the hwmon interface, well, that's a whole different issue... > > Windfarm generically creates sysfs files for all sensors so I suppose it > -could- start exposing them in a more standard interface. > > therm_adt746x creates its own special /sys/devices/temperatures with all > the files in it. I don't want to remove it for now but it might be > worthwhile adding an hwmon interface to it, at least I can still test > on it. Sounds good. > therm_windtunnel is similar but I don't have the HW to test so that's > going to be a bit nastier. > > I hope to have something before the end of the week for you to review. Sure, as soon as you have anything ready, I'll be happy to review it. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
