On Tue, Apr 19, 2011 at 01:30:22PM -0700, Guenter Roeck wrote: > This driver adds support for Si570, Si571, Si598, and Si599 > programmable XO/VCXO. > > Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> > --- > Documentation/misc-devices/si570 | 61 ++++++ > MAINTAINERS | 7 + > drivers/misc/Kconfig | 10 + > drivers/misc/Makefile | 1 + > drivers/misc/si570.c | 398 ++++++++++++++++++++++++++++++++++++++ > include/linux/i2c/si570.h | 23 +++ This file should be in include/linux/platform_data/, right? And as you have created sysfs files, you need to also provide the proper Documentation/ABI/ files. Please add them in your next resend of this patch. Also, please run your patch through scripts/checkpatch.pl before sending it out, and fix the issues it finds, otherwise people will just repeat them here, which is boring... thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html