On Wed, Feb 16, 2011 at 03:51:11PM +0100, Jan Andersson wrote: > On 02/16/2011 03:27 PM, Wolfram Sang wrote: >> Hi Jan, >> >> On Wed, Feb 16, 2011 at 01:30:48PM +0100, Jan Andersson wrote: >>> This patch adds support for the I2CMST core found on LEON/GRLIB SoCs. >>> >>> Signed-off-by: Jan Andersson<jan@xxxxxxxxxxx> >>> --- >>> The I2CMST core is basically the OpenCores I2C master with an AMBA APB >>> interface. This driver re-uses much of i2c-ocores.c. It is submitted as >>> a separate driver since the register interfaces differ sligthly. Also the >>> two IP cores are maintained separately so they may diverge further in >>> the future. >>> >>> The driver is identical in terms of transfer handling and HW control. >>> The original module author string has been kept. >> >> Just judging from this message, it seems that algo could be extracted and used >> by both drivers? Or would this make no sense? >> > > Hi Wolfram, > > The control parts of the *_process, *_isr and *_xfer functions could be > shared by ripping it out and changing the calls used to read/set > registers. > > I considered that change more complex and did not think it to be worth > the trouble for saving ~50 LOC (probably less with added glue). Of > course, it could be beneficial to have the algo part shared if there are > future updates to it. At the same time I suppose that it could be bad to > have the algo part shared if the updates are only valid for one of the > cores. could at-least the contstants be shared? > > Best regards, > Jan > -- > To unsubscribe from this list: send the line "unsubscribe linux-i2c" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Ben Dooks, ben@xxxxxxxxx, http://www.fluff.org/ben/ Large Hadron Colada: A large Pina Colada that makes the universe disappear. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
