On 08/02/11 12:44, Mark Brown wrote: > ... > + goto err_iounmap; > + } > + irq = res->start; > + > + clk = clk_get(&pdev->dev, NULL); > + if (!clk) { This should be: if (!IS_ERR(clk)) { > + ret = -ENOMEM; This should probably be: ret = PTR_ERR(clk); although Ben made some comments in his review re: certain error codes being ignored by the higher layers; I'm not sure if that applies here or not. > + goto err_release_region; > + } > + -- nvpublic -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html