Re: [PATCH 1/3] i2c_intel_mid: Improve error reporting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 25, 2011 at 02:20:48PM +0000, Alan Cox wrote:
> From: Catalin Popescu <catalinx.popescu@xxxxxxxxx>
> 
> The error messages printed from mrst_i2c_abort() didn't give slave address info.
> 
> But I2C device driver developers always need this to check which slave device
> has the problem.

Erm, surely the driver itself should know what i2c device it is communicating
with? Secondly, does this swamp the kernel dmesg buffer when run with the
i2c-detect tool?
 
> This patch enhances the error message format by adding slave address info to
> each error message.

Why not use dev_err() on the i2c device's device state?
 
-- 
Ben Dooks, ben@xxxxxxxxx, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux