Re: [i2c-tools][PATCH] honor CROSS_COMPILE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jean Delvare had written, on 01/10/2011 08:26 AM, the following:
On Sat, 8 Jan 2011 22:01:30 +0100, Wolfram Sang wrote:
On Sat, Jan 08, 2011 at 02:32:21PM -0600, Nishanth Menon wrote:
Wolfram Sang wrote, on 01/08/2011 01:23 PM:
Then again, the vast majority of userspace-projects do not use CROSS_COMPILE.
Build systems like ptxdist and buildroot have done fine with overriding CC so
far. I don't see much gain in that addition.

The same is true for CROSS_COMPILE as well.. since the patch does
still allow CC to be over-ridden (as was the previous behavior), why
not add CROSS_COMPILE as well considering folks who could be cross
compiling just i2ctools without using buildroot and the likes?
You can override CC even without a build-system :) I would sum it up like this:
On the positive side you could call it "more flexible", on the negative side
you could call it "redundant". I wouldn't pick it up, but I surely have no
strong feelings about it. It is up to Jean, after all.

I don't have a strong opinion on this either. But I don't get the point
of setting values for AS, LD, AR etc. when they don't seem to be used
anywhere. And STRIP is set too, but "strip" hard-coded in
tools/Module.mk, so I fail to see how that would work. What am I
missing?
I think I should have done just CC alone. I missed the strip one. but are we interested in having CROSS_COMPILE? if yes, I can cleanup the patch and resubmit.

--
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux