a bit of explanation would be nice here. Something like: Subject: i2c-pxa: make sure the remove callback is called on unbind When a "pxa2xx-i2c" device was unbound (e.g. via sysfs) the remove callback was not called because it was discarded after boot or module load time. Because of that the resources allocated in probe were not freed and so a rebind was impossible. Fix that by moving the remove callback to .devexit.text. This way everyone can understand that a real bug is fixed here. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html