Russell King - ARM Linux wrote:
On Thu, Nov 25, 2010 at 11:55:20PM +0000, Ben Dooks wrote:
diff --git a/arch/arm/include/asm/pxa_i2c.h b/arch/arm/include/asm/pxa_i2c.h
new file mode 100644
index 0000000..f6da8a1
--- /dev/null
+++ b/arch/arm/include/asm/pxa_i2c.h
Anyone an opinion on whther to alter all arch-arm machine includes
or add a re-direct of plat/i2c.h to linux/i2c/pxa-i2c.h
We're not going to litter arch/arm/include/asm with SoC specific includes.
If we start doing this, we'll end up with thousands of files in
arch/arm/include/asm which have no real business being there.
So there's not much option but to NAK this patch before it gets out of
hand.
The reason for this change seems to be because x86 has a different register
layout, and x86 doesn't have the clk API.
And I need to access structs / defines which are defined in arch/arm.
For the former, that can be
dealt with an ifdef along side the register definitions.
Sure. The register definition was moved outside the driver into
arch/../include/asm. So I keep them within the driver and ifdef it.
For the latter, why not just implement a simple clk API implementation
which always returns success, rather than requiring special headers
for various ARM drivers?
This has been done. Patch 3/7 creates arch/x86/include/asm/pxa_i2c.h
which defines clk_get(). So it does not require special header files in
regard to the clk api.
So I'm eliminating arch/./arm/inclide/asm/ files which I introduced.
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
