Em 05-11-2010 18:07, Jean Delvare escreveu:
> Drivers don't need to include <linux/i2c-id.h>, especially not when
> they don't use anything that header file provides.
>
> Signed-off-by: Jean Delvare <khali@xxxxxxxxxxxx>
> Cc: Michael Hunold <michael@xxxxxxx>
> Cc: Mauro Carvalho Chehab <mchehab@xxxxxxxxxxxxx>
I suspect that you want to include it via your tree, so:
Acked-by: Mauro Carvalho Chehab <mchehab@xxxxxxxxxx>
> ---
> drivers/media/common/saa7146_i2c.c | 1 -
> drivers/media/video/ir-kbd-i2c.c | 1 -
> drivers/staging/olpc_dcon/olpc_dcon.c | 1 -
> 3 files changed, 3 deletions(-)
>
> --- linux-2.6.37-rc1.orig/drivers/media/common/saa7146_i2c.c 2010-11-02 09:19:35.000000000 +0100
> +++ linux-2.6.37-rc1/drivers/media/common/saa7146_i2c.c 2010-11-05 15:34:25.000000000 +0100
> @@ -391,7 +391,6 @@ static int saa7146_i2c_xfer(struct i2c_a
>
> /*****************************************************************************/
> /* i2c-adapter helper functions */
> -#include <linux/i2c-id.h>
>
> /* exported algorithm data */
> static struct i2c_algorithm saa7146_algo = {
> --- linux-2.6.37-rc1.orig/drivers/media/video/ir-kbd-i2c.c 2010-11-02 09:19:35.000000000 +0100
> +++ linux-2.6.37-rc1/drivers/media/video/ir-kbd-i2c.c 2010-11-05 15:34:18.000000000 +0100
> @@ -44,7 +44,6 @@
> #include <linux/errno.h>
> #include <linux/slab.h>
> #include <linux/i2c.h>
> -#include <linux/i2c-id.h>
> #include <linux/workqueue.h>
>
> #include <media/ir-core.h>
> --- linux-2.6.37-rc1.orig/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-02 09:19:37.000000000 +0100
> +++ linux-2.6.37-rc1/drivers/staging/olpc_dcon/olpc_dcon.c 2010-11-05 15:34:14.000000000 +0100
> @@ -17,7 +17,6 @@
> #include <linux/console.h>
> #include <linux/i2c.h>
> #include <linux/platform_device.h>
> -#include <linux/i2c-id.h>
> #include <linux/pci.h>
> #include <linux/pci_ids.h>
> #include <linux/interrupt.h>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
