Hi Wolfram,
On Wed, 10 Nov 2010 13:28:19 +0100, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit. This is obsolete meanwhile, so fix it and hope the word will spread.
Thanks for actively tracking these.
> Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx>
> ---
>
> Like last time I suggest to collect acks from the driver authors and merge it
> vie Jean's i2c-tree.
>
> drivers/media/video/imx074.c | 2 --
> drivers/media/video/ov6650.c | 2 --
> drivers/misc/apds9802als.c | 1 -
> drivers/staging/olpc_dcon/olpc_dcon.c | 3 ---
> 4 files changed, 0 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/video/imx074.c b/drivers/media/video/imx074.c
> index 380e459..27b5dfd 100644
> --- a/drivers/media/video/imx074.c
> +++ b/drivers/media/video/imx074.c
> @@ -451,7 +451,6 @@ static int imx074_probe(struct i2c_client *client,
> ret = imx074_video_probe(icd, client);
> if (ret < 0) {
> icd->ops = NULL;
> - i2c_set_clientdata(client, NULL);
> kfree(priv);
> return ret;
> }
> @@ -468,7 +467,6 @@ static int imx074_remove(struct i2c_client *client)
> icd->ops = NULL;
> if (icl->free_bus)
> icl->free_bus(icl);
> - i2c_set_clientdata(client, NULL);
> client->driver = NULL;
This statement seems equally unneeded, maybe you could remove it too?
Unless you want to provide a separate patch for this, as there are 5
other drivers doing the same.
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
