On Thu, Oct 21, 2010 at 10:43:04AM -0400, Jean Delvare wrote: > On Tue, 19 Oct 2010 20:55:08 -0700, Guenter Roeck wrote: > > This patch adds support for PCA9541, an I2C Bus Master Selector. > > The driver is modeled as single channel I2C Multiplexer to be able to utilize > > the I2C multiplexer framework. > > > > Signed-off-by: Guenter Roeck <guenter.roeck@xxxxxxxxxxxx> > > Reviewed-by: Tom Grennan <tom.grennan@xxxxxxxxxxxx> > > --- > > v3 changes: > > - Clarified and cleaned up comments. > > - No longer pass "struct i2c_adapter *" as parameter. > > Get it from client->adapter if needed. > > - No longer pass "struct pca9541 *" as parameter. > > Pass "struct i2c_client *" instead and get "struct pca9541 *" from it > > if needed. > > - Removed "struct i2c_client *client" from struct pca9541 since it is > > no longer needed. > > - Moved "pca9541_release_bus(client);" ahead of i2c_add_mux_adapter() > > to avoid a possible race condition. Also protect the call with > > i2c_lock_adapter() / i2c_unlock_adapter(). > > - Removed __devinit from pca9541_probe() and __devexit from pca9541_remove(). > > Applied, thanks. > > Would you mind adding yourself to MAINTAINERS as a maintainer for this > driver? While the driver is small, it's not trivial and it's difficult > to work on it without the right hardware setup. > Sure. Not intentional - I wanted to do that, just forgot. And I agree, it is pretty much impossible to maintain it unless you have HW to test it. Want me to resubmit or send a separate patch ? Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
