On Tue, Aug 10, 2010 at 10:18 PM, Jean Delvare <khali@xxxxxxxxxxxx> wrote:
> On Mon, 02 Aug 2010 16:16:37 +0900, Magnus Damm wrote:
>> From: Magnus Damm <damm@xxxxxxxxxxxxx>
>>
>> Update the i2c-sh_mobile driver to properly free
>> interrupts. The function sh_mobile_i2c_hook_irqs()
>> is fixed so module both unload and load are working
>> as expected.
>>
>> Signed-off-by: Magnus Damm <damm@xxxxxxxxxxxxx>
>> ---
>>
>> drivers/i2c/busses/i2c-sh_mobile.c | 23 +++++++++++++----------
>> 1 file changed, 13 insertions(+), 10 deletions(-)
>>
>> --- 0001/drivers/i2c/busses/i2c-sh_mobile.c
>> +++ work/drivers/i2c/busses/i2c-sh_mobile.c 2010-08-02 15:14:48.000000000 +0900
>> @@ -538,15 +538,17 @@ static int sh_mobile_i2c_hook_irqs(struc
>> {
>> struct resource *res;
>> int ret = -ENXIO;
>> - int q, m;
>> - int k = 0;
>> - int n = 0;
>> + int n, k = 0;
>
> You can't really hope to get the code right with such variable names.
And your suggestion is...? If you see something wrong with the code
please let me know.
Thanks,
/ magnus
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
