> This is in no way a hwmon chip. Surely misc is a better location for now > (pending the usual discussion about all singing all dancing sensors frameworks). Yep it's moving at the moment > > +#include <linux/module.h> > > +#include <linux/init.h> > > +#include <linux/slab.h> > > +#include <linux/i2c.h> > > +#include <linux/hwmon.h> > > Why these extra hwmon includes? At least at first glance I can't see > any uses of them. The only call to hwmon is to stick this in the > hwmon class. I inherited it for cleanup so these are good points (I've been staring at piles of these for so long extra input is very useful - this is the tip of the iceberg !) > > +#include <linux/hwmon-sysfs.h> > > +#include <linux/hwmon-vid.h> > > +#include <linux/err.h> > > +#include <linux/delay.h> > or any mutex usage? > > +#include <linux/mutex.h> > > +#include <linux/sysfs.h> > > + > > I guess this makes the driver look like many others, but why bother with > the wrapping structure? This is only used to keep track of the hwmon > device to be able to remove it later. Should go - agreed will remove > These address changes looking a little unusual to me. They may well be needed, but > if so can we have an explanatory comment? Will investigate. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
