On Sat, 3 Apr 2010 18:29:39 +0200, Wolfram Sang wrote:
> On Wed, Mar 17, 2010 at 01:59:03PM +0100, Yegor Yefremov wrote:
> > Hi,
> >
> > I'm using PCA9564 attached to a ks8695 SoC. During my efforts to get
> > 2.6.33/34 running on my system I noticed sporadic problems with RTC:
>
> [...]
>
> > static struct i2c_pca9564_pf_platform_data __initdata pca_data ={
> > .gpio = -1,
> > .i2c_clock_speed = 59000,
> > .timeout = 1,
> > };
>
> Commit 8e99ada8deaa9033600cd2c7d0a9366b0e99ab68 changed the timeout settings to
> jiffies. So, one jiffy as timeout will not work. Try 'HZ' here.
>
> > before. Diffing i2c-algo-pca.c between 2.6.26 and 2.6.33 showed that
> > there were some minor changes regarding waiting policy in pca_xfer().
> > Could this be the reason for such behavior? Any idea?
>
> You were almost there, just use 'git log' next time.
So this means the bug isn't in the mainline kernel tree and I can
ignore it?
As a side note, arch/blackfin/mach-bf561/boards/acvilon.c sets timeout
to 10000, so the actual timeout depends on the value of HZ, which is
probably not desirable. Not to mention that a timeout of over one
minute (worst case) doesn't seem too smart ;)
--
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
