Hi Wolfram, On Sun, Feb 28, 2010 at 03:55:02PM +0000, Russell King - ARM Linux wrote: > On Wed, Feb 24, 2010 at 12:01:45PM +0100, Uwe Kleine-König wrote: > > From: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > > > > This talkative function is also called on timeouts. As timeouts can > > happen on regular writes to EEPROMs (no error case), this creates false > > positives. Giving lots of details is interesting only for developers > > anyhow, so just use the function if DEBUG is #defined. > > Are you sure this is safe? If you time out the write before it completes, > how do you know if the write was successful? > > I don't think this is "no error code" nor "false positive". If the timeout > is too short for your EEPROMs, then the timeout needs to be increased. any thoughts about this by you? Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ | -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
