On Tue, Feb 02, 2010 at 01:17:43PM +0100, Wolfram Sang wrote: > When cppcheck found this flaw > > [./i2c/busses/i2c-highlander.c:284]: (style) Warning - using char variable in bit operation > > it was noted that the 'read'-variable could just be removed as read_write can > only be 0 or 1 anyhow. So, we remove the flaw by simplifying the code. > > Reported-by: d binderman <dcb314@xxxxxxxxxxx> > Signed-off-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > Cc: Paul Mundt <lethal@xxxxxxxxxxxx> > Cc: Jean Delvare <khali@xxxxxxxxxxxx> > Cc: Ben Dooks <ben-linux@xxxxxxxxx> Fine with me. Acked-by: Paul Mundt <lethal@xxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html