Grant Likely wrote: > On Tue, Jan 19, 2010 at 1:24 PM, Anatolij Gustschin <agust@xxxxxxx> wrote: >> From: Piotr Ziecik <kosmo@xxxxxxxxxxxx> >> >> - Update Kconfig for i2c-mpc driver. >> - Enable I2C interrupts on MPC5121. >> >> diff --git a/drivers/i2c/busses/i2c-mpc.c b/drivers/i2c/busses/i2c-mpc.c >> index f627001..84eeb25 100644 >> --- a/drivers/i2c/busses/i2c-mpc.c >> +++ b/drivers/i2c/busses/i2c-mpc.c >> @@ -540,6 +540,29 @@ static int __devinit fsl_i2c_probe(struct of_device *op, >> } >> } >> >> + if (of_device_is_compatible(op->node, "fsl,mpc5121-i2c")) { > > Rather than doing stuff like this with explicit compatible checks in > the probe hook, consider using the .data pointer in the of match > table. Yes, and it does also not use the clock setting code of the MPC5200, which should work for the MPC512x as well. I already have a patch in my pipeline, which I will roll out after some more testing. Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html