> Subject: Re: [PATCH 07/10] ARM: PNX4008: move i2c suspend/resume callbacks > into driver > > On Wed, Nov 25, 2009 at 10:19:26PM +0100, Kevin Wells wrote: > > > Subject: Re: [PATCH 07/10] ARM: PNX4008: move i2c suspend/resume > callbacks > > > into driver > > > > > > On Sat, Nov 21, 2009 at 06:27:54PM +0100, Linus Walleij wrote: > > > > If you have this up for testing anyway, would it be advisable to > take > > > this > > > > opportunity to also switch i2c-pnx over to using struct dev_pm_ops? > > > > > > > With the clock change below, suspend and resume won't be needed anymore. > > > > > These patches are only compile-tested, and that's partly why there's > soo > > > many of them - each one does one transformation, which makes it easy > to > > > review for correctness. > > > > > > I'm also hoping that Kevin will test them on later PNX hardware so > that > > > they can be submitted. > > > > All the I2C patches work fine. In regards to the clock being enabled on > > suspend, I think that's a bug - it should be disabled. It only uses > extra > > power keeping the clock gated on when an I2C transaction isn't in > progress. > > The clock can be gated on prior to an I2C transaction starting and > > then gated off at the end of it. This will save a small trickle of > power. > > > > I'll send over patch with these changes. > > I didn't hear any response, so the PNX4008 patches are still hanging > around unmerged, and now have rejects. > I tested the patches and they worked fine. I thought I sent another message saying that... > I'm not attached to these patches so I'm not going to be putting any > additional effort into them (which means I'm not going to be putting > any effort into fixing those rejects or trying to get them merged) > especially as it means that they're now going to have to be maintained > by someone for three months... We use these drivers on several other devices and many variants, I'll work on getting the code into mainline and getting everything cleaned up. I think the changes made the driver better and made our clock support in the mach- area less complex (and much more generic). I've actually updated and tested my local 32xx arch files with these changes and would like to submit those initial files based on those changes, so I do have a very strong interest to get them included.... -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
