On Wed, Sep 30, 2009 at 2:06 PM, Kevin Hilman <khilman@xxxxxxxxxxxxxxxxxxx> wrote: > On Mon, Aug 3, 2009 at 3:11 PM, Kevin Hilman > <khilman@xxxxxxxxxxxxxxxxxxx> wrote: >> Ben Dooks wrote: >>> >>> On Tue, Jul 21, 2009 at 04:09:03PM -0700, Kevin Hilman wrote: >>>> >>>> From: Rajendra Nayak <rnayak@xxxxxx> >>>> >>>> Because of OMAP off-mode, powerdomain can go off when I2C is idle. >>>> Save enough state, and do a re-init for each transfer. >>>> >>>> Additional save/restore state added by Jagadeesh Bhaskar Pakaravoor >>>> (SYSC_REG) and Aaro Koskinen (wakeup sources.) >>>> >>>> Also, The OMAP3430 TRM states: >>>> >>>> "During active mode (I2Ci.I2C_CON[15] I2C_EN bit is set to 1), make no >>>> changes to the I2Ci.I2C_SCLL and I2Ci.I2C_SCLH registers. Changes may >>>> result in unpredictable behavior." >>>> >>>> Hence, the I2C_EN bit should be clearer when modifying these >>>> registers. Please note that clearing the entire I2C_CON register to >>>> disable the I2C module is safe, because the I2C_CON register is >>>> re-configured for each transfer. >>> >>> should this be applied as a bugfix, or kept for next merge window? >> >> next merge window is fine. >> > > Ben, > > It doesn't look like this made it in during the 2.6.32 merge window. > Can you queue it for the -rc series? > ping -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
