-----Original Message----- From: linux-i2c-owner@xxxxxxxxxxxxxxx [mailto:linux-i2c-owner@xxxxxxxxxxxxxxx] On Behalf Of Mark Brown Sent: Tuesday, October 13, 2009 4:54 AM To: Shinya Kuribayashi Cc: baruch@xxxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx; linux-mips@xxxxxxxxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; ben-linux@xxxxxxxxx Subject: Re: [PATCH 07/16] i2c-designware: Set a clock name to DesignWare I2C clock source On Tue, Oct 13, 2009 at 11:50:49AM +0900, Shinya Kuribayashi wrote: > This driver is originally prepared for the ARM kernel where rich and > well-maintained "clkdev" clock framework is available, and clock name > might not be strictly required. ARM's clkdev does slightly fuzzy > matching where it basically gives preference to "struct device" > mathing over "clock id". As long as used for ARM machines, there's no problem. > However, all users of this driver necessarily don't have the same clk > framework with ARM's, as the clk I/F implementation varies depending > on ARCHs and machines. > This patch adds a clock name so that other users with simple/minimum/ > limited clk support could make use of the driver. This seems like something that it'd be better to fix in the relevant clock frameworks in order to try to keep the API consistently usable between platforms. The clkdev matching library that most of the ARM platforms use should be generic enough to be usable elsewhere, there is regular discussion of moving it somewhere more generic. -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
