RE: [PATCH RESEND] I2C: OMAP: Add missing wakeup events

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Aaro!

> -----Original Message-----
> From: linux-omap-owner@xxxxxxxxxxxxxxx [mailto:linux-omap-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Aaro Koskinen
> Sent: Monday, October 12, 2009 5:21 AM
> To: ben-linux@xxxxxxxxx; linux-i2c@xxxxxxxxxxxxxxx
> Cc: linux-omap@xxxxxxxxxxxxxxx; j-pakaravoor@xxxxxx
> Subject: [PATCH RESEND] I2C: OMAP: Add missing wakeup events
> 
> From: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx>
> 
> Include wake up events for receiver overflow and transmitter
> underflow in OMAP_I2C_WE_REG configuration. Also fix a small
> typo.
> 
> Signed-off-by: Jagadeesh Bhaskar Pakaravoor <j-pakaravoor@xxxxxx>
> Signed-off-by: Aaro Koskinen <aaro.koskinen@xxxxxxxxx>
> ---
>  drivers/i2c/busses/i2c-omap.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c
> index 827da08..34ea9ed 100644
> --- a/drivers/i2c/busses/i2c-omap.c
> +++ b/drivers/i2c/busses/i2c-omap.c
> @@ -92,8 +92,10 @@
>  #define OMAP_I2C_STAT_AL	(1 << 0)	/* Arbitration lost int ena */
> 
>  /* I2C WE wakeup enable register */
> -#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakup */
> +#define OMAP_I2C_WE_XDR_WE	(1 << 14)	/* TX drain wakeup */
>  #define OMAP_I2C_WE_RDR_WE	(1 << 13)	/* RX drain wakeup */
> +#define OMAP_I2C_WE_ROVR_WE	(1 << 11)	/* RX overflow wakeup */
> +#define OMAP_I2C_WE_XUDF_WE	(1 << 10)	/* TX underflow wakeup */

These bits are not documented in OMAP3430, they are reserved. How can they be used?

>  #define OMAP_I2C_WE_AAS_WE	(1 << 9)	/* Address as slave wakeup*/
>  #define OMAP_I2C_WE_BF_WE	(1 << 8)	/* Bus free wakeup */
>  #define OMAP_I2C_WE_STC_WE	(1 << 6)	/* Start condition wakeup */
> @@ -104,6 +106,7 @@
>  #define OMAP_I2C_WE_AL_WE	(1 << 0)	/* Arbitration lost wakeup */
> 
>  #define OMAP_I2C_WE_ALL		(OMAP_I2C_WE_XDR_WE |
> OMAP_I2C_WE_RDR_WE | \
> +				OMAP_I2C_WE_ROVR_WE | OMAP_I2C_WE_XUDF_WE | \
>  				OMAP_I2C_WE_AAS_WE | OMAP_I2C_WE_BF_WE | \
>  				OMAP_I2C_WE_STC_WE | OMAP_I2C_WE_GC_WE | \
>  				OMAP_I2C_WE_DRDY_WE | OMAP_I2C_WE_ARDY_WE | \
> --
> 1.6.0.4
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-omap" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Regards
Moiz Sonasath
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux