On Tue, Sep 29, 2009 at 10:24 PM, Mark Brown <broonie@xxxxxxxxxxxxxxxxxxxxxxxxxxx> wrote: > On Tue, Sep 29, 2009 at 09:54:05PM +0800, Richard Zhao wrote: >> On Tue, Sep 29, 2009 at 9:25 PM, Sascha Hauer <s.hauer@xxxxxxxxxxxxxx> wrote: > >> > I think it's generally a good idea to start/stop the clocks when needed >> > as you do here. It should be an extra patch though. > >> You think I should split the patch to three: IBB, reg_dump, clk dis/en ? >> The idea is good, more easy to revert. but sometimes, I think it make >> small things too complex. > > Keeping small things simple is half the reason for doing this - it's not > just bisection, it's also the fact that it's much easier to read and > understand a small patch that does one thing than it is to do the same > with a large patch which makes several unrelated changes. When several > changes are lumped in together it's harder to see the complete version > of any one change in isolation and more effort is required to work out > which goals are being accomplished with any given chunk of the patch. > Thank you all! If you don't have other comments, I will split the patch and send out again tomorrow. Thanks Richard -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
