Hi Jean, Really appreciate your kindly comments on Moorestown I2C driver! I'm really learning a lot from your comments. :) Currently I'm working on those comments, but due to other plenty of work, please expect a slow response on that. :( Another thing needs your help is, can I replace the module_init() function with subsys_initcall() in Moorestown I2C driver? Is it acceptable for I2C subsystem? There is a requirement in Moorestown that certain drivers need I2C driver loaded before those drivers. To achieve this, is subsys_initcall() the only way? Thanks Wen >-----Original Message----- >From: Jean Delvare [mailto:khali@xxxxxxxxxxxx] >Sent: 2009年6月15日 19:51 >To: Wang, Wen W >Cc: Linux I2C >Subject: Re: [PATCH 1/1] I2C: I2C controller driver for Intel Moorestown platform > >Hi Wen, > >Sorry for the late reply. Here comes a full review of your driver. > ?韬{.n?????%??檩??w?{.n???{炳-?)?骅w* jg????????G??⒏ ⒎?:+v???????? ????＂??????
