Hi Ari, One thing that I missed - On Wed, 11 Mar 2009, Paul Walmsley wrote: > > On Fri, Mar 06, 2009 at 03:34:54PM +0200, Ari Kauppi wrote: > > > I have observed some Spurious IRQ's for I2C1 when all kernel hacking options > > > (and thus LOCKDEP) are disabled. > > Ari, are you seeing "Spurious irq XX: XXXXXXXX, please flush posted write > for irq" messages? If so, the correct fix for this is to read from the > device interrupt status register immediately after writing to it. This > forces the ARM to wait until the write to the device is complete. Ari, > could you make this change to i2c-omap.c:omap_i2c_isr() instead, and test > whether this fixes the problem? > > + u32 tmp; > > ... > > omap_i2c_write_reg(dev, OMAP_I2C_STAT_REG, stat); > + tmp = omap_i2c_read_reg(dev, OMAP_I2C_STAT_REG); /* OCP barrier */ You'll also want to make a similar change in omap_i2c_ack_stat(), to add a read immediately after that write. - Paul -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
