On Tue, Mar 10, 2009 at 12:52:22AM +0000, Ben Dooks wrote: > On Fri, Mar 06, 2009 at 03:34:54PM +0200, Ari Kauppi wrote: > > I have observed some Spurious IRQ's for I2C1 when all kernel hacking options > > (and thus LOCKDEP) are disabled. > > > > Applying Richard Woodruff's 'I2C bug fixes for L-O and L-Z' seems to help > > but IRQF_DISABLED is needed for proper behaviour. > > > > Signed-off-by: Ari Kauppi <Ext-Ari.Kauppi@xxxxxxxxx> > > Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx> > > --- > > drivers/i2c/busses/i2c-omap.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/i2c/busses/i2c-omap.c b/drivers/i2c/busses/i2c-omap.c > > index 0c3ed41..18af43f 100644 > > --- a/drivers/i2c/busses/i2c-omap.c > > +++ b/drivers/i2c/busses/i2c-omap.c > > @@ -847,7 +847,7 @@ omap_i2c_probe(struct platform_device *pdev) > > omap_i2c_init(dev); > > > > isr = (dev->rev < OMAP_I2C_REV_2) ? omap_i2c_rev1_isr : omap_i2c_isr; > > - r = request_irq(dev->irq, isr, 0, pdev->name, dev); > > + r = request_irq(dev->irq, isr, IRQF_DISABLED, pdev->name, dev); > > Is disabling all IRQs on the system the right thing to do? if not we could fall into stack overflow, right ? -- balbi -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
