On Thu, 2009-02-12 at 15:05 +0100, Jean Delvare wrote: > > The I2C driver currently known as i2c-s3c2410 is now used by > > several different s3cXXXX SoCs. As such, this patch renames the > > platform data to be SoC agnostic. > This is Ben's call, not mine, but I tend to discourage that kind of > changes. For one thing, they cost more than then bring. And for > another, they may need to be reverted if incompatible hardware appears > in the future. The same I2C controller is found throughout Samsung's s3c24xx and 64xx range. I doubt they'll introduce wildly incompatible peripherals in the same range. > Personally, I read "s3c2410" in these structure names as "S3C 2410 and > compatible", so it looks perfectly right to me, I don't see this as > something which needs to be changed. Whereas I see it as "s3c2410" or at most liberal, "s3c241x". Given there's a family of 10 or more chips which all use this i2c controller, only 4 of which could plausibly be thought of as a 2410 (2410, 2412, 2413, 2416) it seems disingenuously named as-is. The confusion which could ensue (and indeed *does* ensue with some of our customers) seems worth trying to avoid. D. -- Daniel Silverstone http://www.simtec.co.uk/ PGP mail accepted and encouraged. Key Id: 2BC8 4016 2068 7895 -- To unsubscribe from this list: send the line "unsubscribe linux-i2c" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
