Re: [PATCH] I2C: Rename struct s3c2410_platform_i2c to s3c_platform_i2c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 12 Feb 2009 13:49:30 +0000, Daniel Silverstone wrote:
> The I2C driver currently known as i2c-s3c2410 is now used by
> several different s3cXXXX SoCs. As such, this patch renames the
> platform data to be SoC agnostic.
> 
> Signed-Off-By: Simtec Linux Team <linux@xxxxxxxxxxxx>
> Signed-Off-By: Daniel Silverstone <dsilvers@xxxxxxxxxxxx>
> 
> ---
>  arch/arm/mach-s3c2410/mach-bast.c    |    2 +-
>  arch/arm/mach-s3c2410/mach-n30.c     |    2 +-
>  arch/arm/mach-s3c2412/mach-jive.c    |    2 +-
>  arch/arm/plat-s3c/dev-i2c0.c         |    8 ++++----
>  arch/arm/plat-s3c/dev-i2c1.c         |    8 ++++----
>  arch/arm/plat-s3c/include/plat/iic.h |    8 ++++----
>  drivers/i2c/busses/i2c-s3c2410.c     |    6 +++---
>  7 files changed, 18 insertions(+), 18 deletions(-)

This is Ben's call, not mine, but I tend to discourage that kind of
changes. For one thing, they cost more than then bring. And for
another, they may need to be reverted if incompatible hardware appears
in the future.

Personally, I read "s3c2410" in these structure names as "S3C 2410 and
compatible", so it looks perfectly right to me, I don't see this as
something which needs to be changed.

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux GPIO]     [Linux SPI]     [Linux Hardward Monitoring]     [LM Sensors]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux