On Mon, Oct 28, 2024 at 04:01:56PM +0100, Olaf Hering wrote: > Mon, 28 Oct 2024 02:06:20 -0700 Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx>: > > > Thanks for the patch. Changes look good to me, I will suggest to improve this > > log message incase the error type is EIO by suggesting that users verify if > > 'Guest Services' is enabled. > > No error happens if the state of "Guest services" remains unchanged during > the life time of the VM (either "enabled" or "disabled"). Also no error happens > if "Guest services" changes from "disabled" to "enabled". But the error happens > if "Guest services" changes from "enabled" to "disabled". All this is correct. > I think the actual > error "EIO" is not relevant for the commit message. Maybe you mean the second > paragraph should read like this? > > This happens if the state of "Guest services" integration service is changed > from "enabled" to "disabled" at runtime in the VM settings. Right, we can inform user by putting this info in syslog error. - Saurabh
