Mon, 28 Oct 2024 02:06:20 -0700 Saurabh Singh Sengar <ssengar@xxxxxxxxxxxxxxxxxxx>: > Thanks for the patch. Changes look good to me, I will suggest to improve this > log message incase the error type is EIO by suggesting that users verify if > 'Guest Services' is enabled. No error happens if the state of "Guest services" remains unchanged during the life time of the VM (either "enabled" or "disabled"). Also no error happens if "Guest services" changes from "disabled" to "enabled". But the error happens if "Guest services" changes from "enabled" to "disabled". I think the actual error "EIO" is not relevant for the commit message. Maybe you mean the second paragraph should read like this? This happens if the state of "Guest services" integration service is changed from "enabled" to "disabled" at runtime in the VM settings. I'm probably not telling news if I say that this behavior is a regression compared to the hv_utils based variant of fcopy. In the past one could flip the state of "Guest services", it would always come back if state changed to "enabled" again, because the "hv_fcopy" device node came back. With UIO the device node does not come back AFAICS. Not a big deal to reboot the VM in this case. Olaf
Attachment:
pgpy0GNi_vWaf.pgp
Description: Digitale Signatur von OpenPGP
