> -----Original Message----- > From: Jakub Kicinski <kuba@xxxxxxxxxx> > Sent: Tuesday, September 17, 2024 11:04 AM > To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Cc: Erni Sri Satya Vennela <ernis@xxxxxxxxxxxxxxxxxxx>; KY Srinivasan > <kys@xxxxxxxxxxxxx>; wei.liu@xxxxxxxxxx; Dexuan Cui > <decui@xxxxxxxxxxxxx>; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; > pabeni@xxxxxxxxxx; shradhagupta@xxxxxxxxxxxxxxxxxxx; > ahmed.zaki@xxxxxxxxx; colin.i.king@xxxxxxxxx; linux- > hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] net: mana: Add get_link and get_link_ksettings in > ethtool > > On Tue, 17 Sep 2024 14:35:21 +0000 Haiyang Zhang wrote: > > > Any reason why? Sometimes people add this callback for virtual > > > devices to expose some approximate speed, but you're not reporting > > > speed, so I'm curious. > > Speed info isn't available from the HW yet. But we are requesting > > that from HW team. For now, we just add some minimal info, like > > duplex, etc. > > Unless I'm misreading I don't see the answer to the "why?" in your > reply. > > What benefit does reporting duplex on a virtual device bring? > What kind of SW need this current patch? > etc. I'm not aware of any SW has such requirement either. We just want the "ethtool <nic>" cmd can output something we already know. Is this acceptable? Thanks, - Haiyang
