> -----Original Message----- > From: Jakub Kicinski <kuba@xxxxxxxxxx> > Sent: Friday, September 13, 2024 11:24 PM > To: Erni Sri Satya Vennela <ernis@xxxxxxxxxxxxxxxxxxx> > Cc: KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang > <haiyangz@xxxxxxxxxxxxx>; wei.liu@xxxxxxxxxx; Dexuan Cui > <decui@xxxxxxxxxxxxx>; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx; > pabeni@xxxxxxxxxx; shradhagupta@xxxxxxxxxxxxxxxxxxx; > ahmed.zaki@xxxxxxxxx; colin.i.king@xxxxxxxxx; linux- > hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; linux- > kernel@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] net: mana: Add get_link and get_link_ksettings in > ethtool > > On Thu, 12 Sep 2024 00:44:43 -0700 Erni Sri Satya Vennela wrote: > > Add support for the ethtool get_link and get_link_ksettings > > operations. Display standard port information using ethtool. > > Any reason why? Sometimes people add this callback for virtual > devices to expose some approximate speed, but you're not reporting > speed, so I'm curious. Speed info isn't available from the HW yet. But we are requesting that from HW team. For now, we just add some minimal info, like duplex, etc. > > > +static int mana_get_link_ksettings(struct net_device *ndev, > > + struct ethtool_link_ksettings *cmd) > > +{ > > + cmd->base.duplex = DUPLEX_FULL; > > make sense > > > + cmd->base.autoneg = AUTONEG_ENABLE; > > what's the point of autoneg if we show no link info? > DISABLE seems more suitable We don't have strong opinion on this one. @Vennela, you may remove the 3 items related to autoneg. > > > + cmd->base.port = PORT_DA; > > Any reason why DA? I'd think PORT_OTHER may be better? I'm OK with PORT_OTHER too :) Thanks, - Haiyang