> -----Original Message----- > From: Jakub Kicinski <kuba@xxxxxxxxxx> > Sent: Thursday, March 7, 2024 12:02 PM > To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Cc: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx>; Shradha Gupta > <shradhagupta@xxxxxxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux- > hyperv@xxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx; > netdev@xxxxxxxxxxxxxxx; Eric Dumazet <edumazet@xxxxxxxxxx>; Paolo Abeni > <pabeni@xxxxxxxxxx>; Ajay Sharma <sharmaajay@xxxxxxxxxxxxx>; Leon > Romanovsky <leon@xxxxxxxxxx>; Thomas Gleixner <tglx@xxxxxxxxxxxxx>; > Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>; KY Srinivasan > <kys@xxxxxxxxxxxxx>; Wei Liu <wei.liu@xxxxxxxxxx>; Dexuan Cui > <decui@xxxxxxxxxxxxx>; Long Li <longli@xxxxxxxxxxxxx>; Michael Kelley > <mikelley@xxxxxxxxxxxxx> > Subject: Re: [PATCH] net :mana : Add per-cpu stats for MANA device > > On Thu, 7 Mar 2024 15:49:15 +0000 Haiyang Zhang wrote: > > > > Extend 'ethtool -S' output for mana devices to include per-CPU > packet > > > > stats > > > > > > But why? You already have per queue stats. > > Yes. But the q to cpu binding is dynamic, we also want the per-CPU stat > > to analyze the CPU usage by counting the packets and bytes on each CPU. > > Dynamic is a bit of an exaggeration, right? On a well-configured system > each CPU should use a single queue assigned thru XPS. And for manual > debug bpftrace should serve the purpose quite well. Some programs, like irqbalancer can dynamically change the CPU affinity, so we want to add the per-CPU counters for better understanding of the CPU usage. Thanks, - Haiyang
