> -----Original Message----- > From: Jakub Kicinski <kuba@xxxxxxxxxx> > Sent: Thursday, March 7, 2024 10:29 AM > To: Shradha Gupta <shradhagupta@xxxxxxxxxxxxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-hyperv@xxxxxxxxxxxxxxx; linux- > rdma@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Eric Dumazet > <edumazet@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx>; Ajay Sharma > <sharmaajay@xxxxxxxxxxxxx>; Leon Romanovsky <leon@xxxxxxxxxx>; Thomas > Gleixner <tglx@xxxxxxxxxxxxx>; Sebastian Andrzej Siewior > <bigeasy@xxxxxxxxxxxxx>; KY Srinivasan <kys@xxxxxxxxxxxxx>; Haiyang Zhang > <haiyangz@xxxxxxxxxxxxx>; Wei Liu <wei.liu@xxxxxxxxxx>; Dexuan Cui > <decui@xxxxxxxxxxxxx>; Long Li <longli@xxxxxxxxxxxxx>; Michael Kelley > <mikelley@xxxxxxxxxxxxx>; Shradha Gupta <shradhagupta@xxxxxxxxxxxxx> > Subject: Re: [PATCH] net :mana : Add per-cpu stats for MANA device > > On Thu, 7 Mar 2024 06:52:12 -0800 Shradha Gupta wrote: > > Extend 'ethtool -S' output for mana devices to include per-CPU packet > > stats > > But why? You already have per queue stats. Yes. But the q to cpu binding is dynamic, we also want the per-CPU stat to analyze the CPU usage by counting the packets and bytes on each CPU. > > > Built-on: Ubuntu22 > > Tested-on: Ubuntu22 > > I understand when people mention testing driver changes on particular > SKUs of supported devices, that adds meaningful info. I don't understand > what "built" and "tested" on a distro is supposed to tell us. > Honest question, what is the value of this? @Shradha Gupta Please add the tested SKU and test case here. Or, you don't have to include test info with the patch. Thanks, - Haiyang
