On Mon, Jul 11, 2022 at 01:29:08AM +0000, Dexuan Cui wrote: > > From: longli@xxxxxxxxxxxxxxxxx <longli@xxxxxxxxxxxxxxxxx> > > Sent: Wednesday, June 15, 2022 7:07 PM > > > > The MANA hardware support protection domain and memory registration for > s/support/supports > > > diff --git a/drivers/net/ethernet/microsoft/mana/gdma.h > > b/drivers/net/ethernet/microsoft/mana/gdma.h > > index f945755760dc..b1bec8ab5695 100644 > > --- a/drivers/net/ethernet/microsoft/mana/gdma.h > > +++ b/drivers/net/ethernet/microsoft/mana/gdma.h > > @@ -27,6 +27,10 @@ enum gdma_request_type { > > GDMA_CREATE_DMA_REGION = 25, > > GDMA_DMA_REGION_ADD_PAGES = 26, > > GDMA_DESTROY_DMA_REGION = 27, > > + GDMA_CREATE_PD = 29, > > + GDMA_DESTROY_PD = 30, > > + GDMA_CREATE_MR = 31, > > + GDMA_DESTROY_MR = 32, > These are not used in this patch. They're used in the 12th > patch for the first time. Can we move these to that patch? This looks like RDMA code anyhow, why is it under net/ethernet? Jason