On Mon, Jul 11, 2022 at 01:13:50AM +0000, Dexuan Cui wrote: > > From: longli@xxxxxxxxxxxxxxxxx <longli@xxxxxxxxxxxxxxxxx> > > Sent: Wednesday, June 15, 2022 7:07 PM > > ... > > +EXPORT_SYMBOL(mana_gd_destroy_doorbell_page); > Can this be EXPORT_SYMBOL_GPL? > > > +EXPORT_SYMBOL(mana_gd_allocate_doorbell_page); > EXPORT_SYMBOL_GPL? Can you think about using the symbol namespaces here? Nobody else has done it yet, but I think we should be... Jason