Paolo Bonzini <pbonzini@xxxxxxxxxx> writes: > On 6/13/22 15:39, Vitaly Kuznetsov wrote: >> - tlb_flush_fifo = kvm_hv_get_tlb_flush_fifo(vcpu); >> + tlb_flush_fifo = kvm_hv_get_tlb_flush_fifo(vcpu, is_guest_mode(vcpu)); >> > > Any reason to add this parameter? Yes) Other users (all from kvm_hv_flush_tlb()) set this parameter based on whether the calling vCPU (*not* the destination vCPU, which is the first parameter) is in guest mode or not. > It is always set to is_guest_mode(vcpu) and, even if it wasn't, I > would add the parameter directly in patch 11. I can move to Patch11 if necessary. -- Vitaly